Better filename 51y66

[dirtyacc]

When link with HTTP header

Code: Select all

Content-Disposition: attachment; filename=

FDM is horrible if it's non-ASCII character.

FDM 5 preview is fixed, while FDM 3.9.x is not yet.

1. urlencode：

Code: Select all

Content-Disposition: attachment;filename="J.TEST%2BEF%2B100-109%E5%90%AC%E5%8A%9B%E5%8E%9F%E6%96%87.rar"

Chrome built-in : J.TEST+EF+100-109听力原文.rar
FDM: J.TEST%2BEF%2B100-109%E5%90%AC%E5%8A%9B%E5%8E%9F%E6%96%87.rar

2. Base64：

Code: Select all

Content-Disposition: attachment; filename="=?UTF8?B?c3RydXRzMi4w5Lit5paH5pWZ56iLLmNobQ==?="

Chrome built-in : struts2.0中文教程.chm
FDM:=_UTF8_B_c3RydXRzMi4w5Lit5paH5pWZ56iLLmNobQ==_=

3. RFC2231 standard：

Code: Select all

Content-Disposition: attachment; filename*=UTF-8''%E5%9B%9E%E6%89%A7.msg

Chrome built-in:回执.msg
FDM:%E5%9B%9E%E6%89%A7.msg

4. Direct Name：

Code: Select all

Content-Disposition: attachment;filename="序列号.txt"

Chrome built-in:序列号.txt
FDM:搴忓垪鍙_txt

It's not that hard in this decode part... please fix it.

[dirtyacc]

All test is done by using Fiddle to modify the HTTP header.

CHROME version 44
FDM version 3.9.6
OS: Win 7 64bit locale setting Simplified Chinese

I think the system locale setting will affects the 4. direct name, because FDM save the UTF8 name directly to the locale ASCII extent code.In Simplified Chineses, it will be GB2312 or GBK, so
序列号.txt -> 搴忓垪鍙?txt
For Japanese Windows, it will be
序列号.txt -> 蠎丞・蜿ｷ.txt
A Russian Windows, it will be
序列号.txt -> еєЏе€—еЏ·.txt
Total disaster


For more sophisticated testcase, you can check here:
http://greenbytes.de/tech/tc2231/

[dirtyacc]

At last, something off topic.

This issue is so simple that a novice coder can deal with it... but unfortunately, somehow this open source program don't provide the latest code in the sourceforge.... make other have no way to help your guys out for reason nobody know why.

It's a deal-breaker to a manager for a non-ASCII characters language s. All those group and other managing features will make no sense when manager don't make the name right.

[Usher]

This issue is so simple that a novice coder can deal with it... but unfortunately, somehow this open source program don't provide the latest code in the sourceforge....

If it's so easy to fix then you can source code for 3.9.5 version (it uses the same codebase for Unicode ) and provide a diff for that code. Even a novice coder knows what diff is and how to deal with it.

[dirtyacc]

This issue is so simple that a novice coder can deal with it... but unfortunately, somehow this open source program don't provide the latest code in the sourceforge....

If it's so easy to fix then you can source code for 3.9.5 version (it uses the same codebase for Unicode ) and provide a diff for that code. Even a novice coder knows what diff is and how to deal with it.

thank you. it's my or anyone who would like to look into it's faults, that we hesitate because we don't get the latest source. Which any change we made may conflict with the updated code.